fix: clear only session-owned files instead of entire upload folder#85
Open
Aman-Cool wants to merge 2 commits into
Open
fix: clear only session-owned files instead of entire upload folder#85Aman-Cool wants to merge 2 commits into
Aman-Cool wants to merge 2 commits into
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues / Pull Requests
NA
Description
Found this while looking at the upload folder handling. When any user clicked "Clear", the code was looping through the entire shared upload folder and deleting every file in it, not just theirs. So if two people were using the app at the same time and one of them hit clear, the other person's file would just vanish mid-computation with no explanation.
Fixed it by tracking which files belong to which session at upload time, and only deleting those on clear.
What changes are proposed in this pull request?
Checklist: