chore: fix some nits for make check-python#1169
Merged
lyj715824 merged 4 commits intoiflytek:mainfrom Apr 14, 2026
Merged
Conversation
Signed-off-by: dongjiang <dongjiang1989@126.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request focuses on code cleanup and refactoring across various modules, including the removal of unused imports, fixing indentation in test files, and standardizing formatting for SQL queries and f-strings. In core/common/service/oss/s3_service.py, the exception handling logic was modified. However, the reviewer identified critical issues in this file where non-exception objects (a response object and a dictionary) were used in the 'from' clause of raise statements, which would result in runtime TypeErrors.
|
|
dongjiang1989
changed the title
Signed-off-by: dongjiang <dongjiang1989@126.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: dongjiang <dongjiang2010@gmail.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: dongjiang <dongjiang2010@gmail.com>
Contributor
Author
|
cc @scguoi ptal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Just some nits for make check
Type of Change
Related Issue
Changes
Testing
Screenshots (if applicable)
Checklist