fix: support both _init_elsdk.py and _elsdk_.py (irispython >= 3.4 rename)#59
Open
isc-tdyar wants to merge 12 commits intointersystems-community:mainfrom
Open
fix: support both _init_elsdk.py and _elsdk_.py (irispython >= 3.4 rename)#59isc-tdyar wants to merge 12 commits intointersystems-community:mainfrom
isc-tdyar wants to merge 12 commits intointersystems-community:mainfrom
Conversation
…ion framework (v0.5.15)
…ity/feature/llm-cache-and-evaluation LLM Caching, Connection Hardening, and Evaluation Framework (v0.5.15)
… PyPI publication
isc-tdyar
pushed a commit
that referenced
this pull request
Mar 29, 2026
…uction-ready) T001-T026 complete: - scripts/setup_spike_env.sh + deploy_colbert_sp.sh - iris_vector_rag/pipelines/colbert_iris/sp/ColBERTSearch.cls (Language=python SqlProc, Stage1 per-token centroid scan, Stage1.5 DocCentroids IN-list, Stage 2 GROUP BY MAX VECTOR_DOT_PRODUCT, JSON return) - PLAIDSearcher.search_via_sp() in plaid.py - tests/colbert_iris/test_colbert_sp.py: 12 pass, 2 xfail xfail: test_search_via_sp_matches_search (overlap depends on K config) xfail: test_stage_timing_assertions (Stage2 1189ms > budget, K=64) - PR #59 opened: intersystems-community/iris-vector-rag fix/_elsdk_-rename Performance status — SP does NOT beat Phase 2 HNSW: Phase 2 HNSW: p50=391ms at T5K Phase 3 SP: Stage2=1189ms at T5K (K=64, 400-doc batches) Root cause: Stage2 issues n_qtoks * ceil(n_candidates/400) SQL calls. Each GROUP BY MAX over 400 docs * 53 toks = 21K VECTOR_DOT_PRODUCT/call. Next direction: iris-vector-graph globals-based approach. iris-vector-graph v1.19+ ships ^NKG integer-encoded inverted index. ^ColBERTIdx(centroid_id, doc_id) via iris.gref() = sub-1ms Stage1.5. But Stage2 remains the killer — needs a different architecture.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
_get_iris_dbapi_module()iniris_vector_rag/common/iris_dbapi_connector.pyonly searches for_init_elsdk.py. Inintersystems-irispython >= 3.4the file was renamed to_elsdk_.py. The search loop finds nothing,connect()is never injected, and all DBAPI connections returnNone.Workaround (users can apply themselves):
Fix
Add an inner loop that checks both filenames for each search directory:
One inner
forloop, no new logic. Backward-compatible — old packages (with_init_elsdk.py) still work; new packages (with_elsdk_.py) now work too.Testing
Verified against
intersystems-irispython 5.3.1(which ships_elsdk_.py) on macOS ARM64 and Ubuntu ARM64.