fix: resolve entity editing workflow, and dayjs runtime crashes#19
Open
Bodeayman wants to merge 2 commits intoistSOS:mainfrom
Open
fix: resolve entity editing workflow, and dayjs runtime crashes#19Bodeayman wants to merge 2 commits intoistSOS:mainfrom
Bodeayman wants to merge 2 commits intoistSOS:mainfrom
Conversation
…reference and initialized dayjs with the UTC plugin to prevent crashes when loading the datastream data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Closes Issue #18
Overview
This PR addresses several critical UI and integration issues in the SensorThings entity management workflow, specifically focusing on the Edit functionality, dashboard stability, and backend integration.
Key Changes
1. Fixed Entity Editing Workflow
editFormStateand correspondingoperation="edit"modal inHome.tsxthat were previously missing or non-functional.DatastreamTable.tsxwhere therenderCellcallback was capturing outdated references to theonEditDatastreamhandler. The edit button now reliably triggers the modal.toDatastreamFormDataand other utility helpers to ensure entity data is correctly mapped from the API response to the form fields.2. Enhanced Dashboard Stability
dayjswith theutcplugin inHome.tsx. This prevents runtime crashes when processing datastream time ranges (which usedayjs.utc()).3. Backend Integration (422 Error Fixes)
locations.ts,sensors.ts, etc.) to comply with the backend's strict requirement for a commit message on all POST/PATCH operations, resolving several 422 Unprocessable Entity errors.Verification Results