perf: Optimize dev container startup using anonymous volume for node_modules#22
Open
KinshukSS2 wants to merge 1 commit intoistSOS:mainfrom
Open
perf: Optimize dev container startup using anonymous volume for node_modules#22KinshukSS2 wants to merge 1 commit intoistSOS:mainfrom
KinshukSS2 wants to merge 1 commit intoistSOS:mainfrom
Conversation
205adca to
0f304ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
this PR removes runtime dependency installation from dev container startup and replaces it with a persistent container-side dependency strategy.
What Changed
docker-compose_dev.ymlto runnpm run devdirectly./home/node/app/node_modules.ui/Dockerfile.devto install dependencies during image build usingnpm ci.README.mddev command references to match the compose file used by this change.Why This Is Better
npm installon each startup.Validation
npm run dev.sh: next: not founderror.fixes #21