Skip to content

fix(parser): prevent webhook body with 'key' field from being silently dropped (fixes #5333) #6230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asheesh-devops wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −9
Open

fix(parser): prevent webhook body with 'key' field from being silently dropped (fixes #5333) #6230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions keep/parser/parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,15 +474,20 @@ def parse_provider_parameters(provider_parameters: dict) -> dict:
parameter
]
elif isinstance(provider_parameters[parameter], dict):
try:
parsed_provider_parameters[parameter_name] = StepProviderParameter(
**provider_parameters[parameter]
)
except Exception:
# It could be a dict/list but not of ProviderParameter type
parsed_provider_parameters[parameter_name] = provider_parameters[
parameter
]
param_value = provider_parameters[parameter]
# Only coerce to StepProviderParameter if the dict exclusively
# contains its known fields — prevents user dicts with a "key"
# field from being silently converted and losing other data.
known_fields = {"key", "safe", "default"}
if param_value.keys() <= known_fields and "key" in param_value:
try:
parsed_provider_parameters[parameter_name] = StepProviderParameter(
**param_value
)
except Exception:
parsed_provider_parameters[parameter_name] = param_value
else:
parsed_provider_parameters[parameter_name] = param_value
return parsed_provider_parameters

def _parse_steps(
Expand Down
Loading