Skip to content

Resolve some compiler warnings #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vincent-richard merged 3 commits into from
Nov 4, 2025
Merged

Resolve some compiler warnings #328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
25cd740
build: resolve 2 instances of -Wpessimizing-move
jengelh Oct 28, 2025
50752a3
build: resolve 1 instance of -Wunused-but-set-variable
jengelh Oct 28, 2025
5c9b31a
build: resolve 2 instances of -Wimplicit-int-conversion
jengelh Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/vmime/net/imap/IMAPMessage.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ IMAPMessage::IMAPMessage(
)
: m_folder(folder),
m_num(num),
m_size(-1U),
m_size(-1),
m_flags(FLAG_UNDEFINED),
m_expunged(false),
m_modseq(0),
Expand Down Expand Up @@ -180,7 +180,7 @@ vmime_uint64 IMAPMessage::getModSequence() const {

size_t IMAPMessage::getSize() const {

if (m_size == -1U) {
if (m_size == static_cast<size_t>(-1)) {
throw exceptions::unfetched_object();
}

Expand Down
10 changes: 2 additions & 8 deletions src/vmime/net/imap/IMAPParser.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -956,7 +956,6 @@ class VMIME_EXPORT IMAPParser : public object {
bool parseImpl(IMAPParser& parser, string& line, size_t* currentPos) {

size_t pos = *currentPos;
size_t len = 0;
bool valid = false;

value.reserve(line.length() - pos);
Expand All @@ -977,7 +976,6 @@ class VMIME_EXPORT IMAPParser : public object {
quoted = false;

++pos;
++len;

} else {

Expand All @@ -986,7 +984,6 @@ class VMIME_EXPORT IMAPParser : public object {
quoted = true;

++pos;
++len;

} else if (c == '"') {

Expand All @@ -999,7 +996,6 @@ class VMIME_EXPORT IMAPParser : public object {
value += c;

++pos;
++len;

} else {

Expand Down Expand Up @@ -3712,7 +3708,7 @@ class VMIME_EXPORT IMAPParser : public object {

VIMAP_PARSER_CHECK(one_char <'('> );

items.push_back(std::move(std::unique_ptr <msg_att_item>(parser.get <msg_att_item>(line, &pos))));
items.push_back(std::unique_ptr <msg_att_item>(parser.get <msg_att_item>(line, &pos)));

while (!VIMAP_PARSER_TRY_CHECK(one_char <')'> )) {
VIMAP_PARSER_CHECK(SPACE);
Expand Down Expand Up @@ -4501,9 +4497,7 @@ class VMIME_EXPORT IMAPParser : public object {
while ((resp = parser.get <IMAPParser::continue_req_or_response_data>(curLine, &pos))) {

continue_req_or_response_data.push_back(
std::move(
std::unique_ptr <IMAPParser::continue_req_or_response_data>(resp)
)
std::unique_ptr <IMAPParser::continue_req_or_response_data>(resp)
);

// Partial response (continue_req)
Expand Down