Skip to content

WIP: softly connect to cloudwego-contrib/cwgo-pkg#36

Open
smx-Morgan wants to merge 12 commits into
kitex-contrib:mainfrom
smx-Morgan:main
Open

WIP: softly connect to cloudwego-contrib/cwgo-pkg#36
smx-Morgan wants to merge 12 commits into
kitex-contrib:mainfrom
smx-Morgan:main

Conversation

@smx-Morgan
Copy link
Copy Markdown
Member

软连接到cloudwego-contrib/cwgo-pkg

@bytedance-oss-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: smx-Morgan
To complete the pull request process, please assign joway after the PR has been reviewed.
You can assign the PR to them by writing /assign @joway in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

3 similar comments
@bytedance-oss-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: smx-Morgan
To complete the pull request process, please assign joway after the PR has been reviewed.
You can assign the PR to them by writing /assign @joway in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bytedance-oss-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: smx-Morgan
To complete the pull request process, please assign joway after the PR has been reviewed.
You can assign the PR to them by writing /assign @joway in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bytedance-oss-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: smx-Morgan
To complete the pull request process, please assign joway after the PR has been reviewed.
You can assign the PR to them by writing /assign @joway in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Comment thread go.mod

replace github.com/apache/thrift => github.com/apache/thrift v0.13.0

replace github.com/cloudwego-contrib/cwgo-pkg/registry/nacos => github.com/smx-Morgan/cwgo-pkg/registry/nacos v0.0.0-20241016000926-d56ef7e0f578
Copy link
Copy Markdown
Member

@whalecold whalecold Oct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

registry/nacos 这部分代码看起来还没合并到 cwgo-pkg 仓库上,等 cwgo-pkg 先合并吧。再问下这个 PR 的上下文是啥呀,为什么要挪过去~

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还没有合并,这个pr是看看壳化到cwgo-pkg仓库的可行性,合并之后会重新修改这个pr的代码。挪过去的原因是 希望Hertz 与 Kitex 相同类型的组件能够同步扩展,不需要提多次pr。

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

那我先把标题打上 WIP 了

@whalecold whalecold changed the title softly connect to cloudwego-contrib/cwgo-pkg WIP: softly connect to cloudwego-contrib/cwgo-pkg Oct 22, 2024
@bytedance-oss-robot bytedance-oss-robot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants