use the napiVersion and skipTest primitives for porting test_cannot_run_js#3
Merged
kraenhansen merged 1 commit intokraenhansen:feat/port-test-cannot-run-jsfrom Apr 25, 2026
Conversation
bavulapati
changed the title
bavulapati
changed the title
kraenhansen
force-pushed
the
feat/port-test-cannot-run-js
branch
from
a0f9aee to
a590d2c
Compare
Signed-off-by: Balakrishna Avulapati <ba@bavulapati.com>
kraenhansen
force-pushed
the
feat/port-test-cannot-run-js
branch
from
f267a30 to
264808e
Compare
kraenhansen
merged commit b988c69
into
kraenhansen:feat/port-test-cannot-run-js
13 checks passed
Owner
|
And thanks here as well 🙂 |
Author
|
I think I missed a detail here. My bad. I left a comment on nodejs#28 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address nodejs#32 (comment)
The changes look complex as the target branch needs a rebase. Once rebased, it is a simple change.