Skip to content

ci: improve SDLC pipeline readiness and AgentReady score#150

Open
maiqueb wants to merge 2 commits into
kubevirt:mainfrom
maiqueb:worktree-enable-sldc-pipeline
Open

ci: improve SDLC pipeline readiness and AgentReady score#150
maiqueb wants to merge 2 commits into
kubevirt:mainfrom
maiqueb:worktree-enable-sldc-pipeline

Conversation

@maiqueb
Copy link
Copy Markdown
Collaborator

@maiqueb maiqueb commented Apr 24, 2026

What this PR does / why we need it:
Add dependency security scanning (Dependabot, CodeQL, govulncheck), pre-commit hooks, conventional commit enforcement, issue templates, architecture decision records, and markdownlint config. Upgrade CI action versions, enable Go module caching, and split checks into parallel jobs for faster feedback.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Apr 24, 2026
@kubevirt-bot kubevirt-bot requested review from oshoval and qinqon April 24, 2026 10:41
@kubevirt-bot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign qinqon for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the project's SDLC pipeline and overall repository maturity. By introducing automated security scanning, standardized development workflows, and optimized CI configurations, the changes ensure better code quality, faster build times, and improved maintainability for current and future contributors.

Highlights

  • Security and Compliance: Integrated Dependabot for dependency management, CodeQL for security analysis, and govulncheck to identify vulnerabilities in Go dependencies.
  • Development Workflow: Introduced pre-commit hooks for linting and conventional commit enforcement, along with standardized issue templates and Architecture Decision Records (ADRs).
  • CI/CD Optimization: Upgraded CI action versions, enabled Go module caching, and parallelized CI jobs to improve pipeline performance and feedback loops.
Ignored Files
  • Ignored by pattern: .github/workflows/** (4)
    • .github/workflows/checks.yaml
    • .github/workflows/nightly.yaml
    • .github/workflows/publish-img.yaml
    • .github/workflows/security.yaml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces foundational project configurations, including issue templates, dependabot settings, linting rules, pre-commit hooks, and initial Architecture Decision Records (ADRs). Feedback identifies an invalid version for the golangci-lint pre-commit hook and recommends enabling vendoring in Dependabot to maintain consistency with the project's decision to check in the vendor directory.

Comment thread .pre-commit-config.yaml
Comment thread .github/dependabot.yml
@github-advanced-security
Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@maiqueb maiqueb force-pushed the worktree-enable-sldc-pipeline branch from 76e2be3 to 01ada0b Compare April 24, 2026 10:54
@kubevirt-bot kubevirt-bot added dco-signoff: no Indicates the PR's author has not DCO signed all their commits. size/XL and removed dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/L labels Apr 24, 2026
@maiqueb maiqueb force-pushed the worktree-enable-sldc-pipeline branch from 01ada0b to 009e9a4 Compare April 24, 2026 10:55
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Apr 24, 2026
maiqueb and others added 2 commits April 24, 2026 12:06
Add dependency security scanning (Dependabot, CodeQL, govulncheck),
pre-commit hooks, conventional commit enforcement, issue templates,
architecture decision records, and markdownlint config. Upgrade CI
action versions, enable Go module caching, and split checks into
parallel jobs for faster feedback.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
Replace setup-go built-in cache with explicit actions/cache steps
so CI caching is visible to pipeline analysis tools. Convert
.golangci.json to .golangci.yml for broader linter detection
compatibility.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
@maiqueb maiqueb force-pushed the worktree-enable-sldc-pipeline branch from 009e9a4 to be40d77 Compare April 24, 2026 11:07
@maiqueb maiqueb requested review from RamLavi and removed request for oshoval April 24, 2026 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants