Open
Conversation
Signed-off-by: shivam tyagi <shivamtyagi@shivams-MacBook-Air.local>
Author
|
@Rajesh-Nagarajan-11 please review! thanks |
Rajesh-Nagarajan-11
approved these changes
Apr 10, 2026
saurabhraghuvanshii
suggested changes
Apr 13, 2026
Makefile
Outdated
| npm run test | ||
|
|
||
| # Clean up build artifacts and installed modules | ||
| clean: |
Member
There was a problem hiding this comment.
@indevi it should be coming from package.json means add a clean script in package.json then use like npm run clean.
Author
There was a problem hiding this comment.
okay considering the scope, its best i remove clean command
saurabhraghuvanshii
suggested changes
Apr 13, 2026
| # Install project dependencies | ||
| install: | ||
| npm install | ||
|
|
Member
There was a problem hiding this comment.
add make site it should run both npm install then npm run dev
Author
There was a problem hiding this comment.
hope this is what you are looking for here @saurabhraghuvanshii
Member
There was a problem hiding this comment.
@indevi this is good but can you refer this https://github.com/layer5io/layer5/blob/master/Makefile once
Signed-off-by: shivam tyagi <shivamtyagi@shivams-MacBook-Air.local>
Author
|
@saurabhraghuvanshii thanks for the indepth help, let me know if this improvements are good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes #42
Signed commits