Skip to content

chore: make Glob.ofString? public#13563

Open
kim-em wants to merge 1 commit intomasterfrom
glob_of_string
Open

chore: make Glob.ofString? public#13563
kim-em wants to merge 1 commit intomasterfrom
glob_of_string

Conversation

@kim-em
Copy link
Copy Markdown
Collaborator

@kim-em kim-em commented Apr 29, 2026

This PR makes Glob.ofString? public, allowing removing the last use of open private from Mathlib.

@kim-em kim-em requested a review from tydeu as a code owner April 29, 2026 01:03
@kim-em kim-em added the changelog-lake Lake label Apr 29, 2026
@github-actions github-actions Bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Apr 29, 2026
@mathlib-lean-pr-testing
Copy link
Copy Markdown

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 9df737d49283c81413c7e000478ae5c6f5397f64 --onto 3c6317b6d77a565b4217532d1190ac6955dba842. You can force Mathlib CI using the force-mathlib-ci label. (2026-04-29 01:54:52)

@leanprover-bot
Copy link
Copy Markdown
Collaborator

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase 9df737d49283c81413c7e000478ae5c6f5397f64 --onto 3fc99eef102549c743c6c63547983319bfae6f01. You can force reference manual CI using the force-manual-ci label. (2026-04-29 01:54:53)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog-lake Lake toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants