Skip to content

Orcid two factor authentication#32

Open
JackBlackLight wants to merge 3 commits into
leibniz-psychology:masterfrom
cul:orcid-two-factor-authentication
Open

Orcid two factor authentication#32
JackBlackLight wants to merge 3 commits into
leibniz-psychology:masterfrom
cul:orcid-two-factor-authentication

Conversation

@JackBlackLight
Copy link
Copy Markdown

Thanks for your work on this plugin. We will be using it on our OJS instance with OrcId as our openid provider, but in addition, we are requiring our users to enable 2FA in their OrcId accounts. The code in this PR enforces the 2FA requirement and adds this option to the OrcId section of the settings form.

Also, I was able to get the plugin working without requiring the vendor autoloader.php file on line 3 of OpenIDHandler. I'm not sure if I’m missing something important there or if that is leftover from a previous approach.

-Jack

@RBoelter
Copy link
Copy Markdown

Without autoload.php and the dependent phpseclib lib, it is not possible to use OpenID providers with a cert modulus and exponent. You need to run composer install to create the vendor folder and load the dependencies. It might work with ORCID without autoload, but I am 100% sure that you have eliminated e.g. Keycloak as provider.

Copy link
Copy Markdown

@RBoelter RBoelter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change // $loader = require('plugins/generic/openid/vendor/autoload.php');
to $loader = require('plugins/generic/openid/vendor/autoload.php');
and run composer install in your terminal

@JackBlackLight
Copy link
Copy Markdown
Author

Thanks for your feedback. I've restored the autoloader requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants