Open
Conversation
The DIRECT_SQL find methodology was an experimental optimization (GCN-38382) that duplicated the default UNIQUE_ID behavior with extra raw SQL + retry logic. Removing it simplifies queryLatest(), eliminates 6 constructors, and halves the test matrix from 12 to 6 parameterized instances. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #600 +/- ##
=========================================
Coverage 65.14% 65.15%
+ Complexity 1692 1689 -3
=========================================
Files 141 141
Lines 6668 6646 -22
Branches 809 806 -3
=========================================
- Hits 4344 4330 -14
+ Misses 1973 1965 -8
Partials 351 351 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yangyangv2
approved these changes
Feb 19, 2026
Contributor
yangyangv2
left a comment
There was a problem hiding this comment.
LGTM, thanks for the clean up!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FindMethodologyenum (UNIQUE_ID,DIRECT_SQL,QUERY_BUILDER) and all associated constructors/fields fromEbeanLocalDAOqueryLatest()by removing theDIRECT_SQLbranch (raw SQL + retry logic that duplicated the default_server.find()behavior)DIRECT_SQLpath was an experimental optimization (GCN-38382) that is no longer neededTesting Done
./gradlew :dao-impl:ebean-dao:testpasses with all 6 parameterized instancesFindMethodologyconstructorsChecklist