Skip to content

Remove FindMethodology enum from EbeanLocalDAO#600

Open
jphui wants to merge 1 commit intomasterfrom
remove-find-methodology
Open

Remove FindMethodology enum from EbeanLocalDAO#600
jphui wants to merge 1 commit intomasterfrom
remove-find-methodology

Conversation

@jphui
Copy link
Copy Markdown
Contributor

@jphui jphui commented Feb 19, 2026

Summary

  • Remove the FindMethodology enum (UNIQUE_ID, DIRECT_SQL, QUERY_BUILDER) and all associated constructors/fields from EbeanLocalDAO
  • Simplify queryLatest() by removing the DIRECT_SQL branch (raw SQL + retry logic that duplicated the default _server.find() behavior)
  • Reduce the test matrix from 12 to 6 parameterized instances, cutting test execution time roughly in half
  • The DIRECT_SQL path was an experimental optimization (GCN-38382) that is no longer needed

Testing Done

  • ./gradlew :dao-impl:ebean-dao:test passes with all 6 parameterized instances
  • Verify no downstream consumers reference FindMethodology constructors

Checklist

The DIRECT_SQL find methodology was an experimental optimization
(GCN-38382) that duplicated the default UNIQUE_ID behavior with
extra raw SQL + retry logic. Removing it simplifies queryLatest(),
eliminates 6 constructors, and halves the test matrix from 12 to 6
parameterized instances.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.15%. Comparing base (40b7d5f) to head (6441de5).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #600   +/-   ##
=========================================
  Coverage     65.14%   65.15%           
+ Complexity     1692     1689    -3     
=========================================
  Files           141      141           
  Lines          6668     6646   -22     
  Branches        809      806    -3     
=========================================
- Hits           4344     4330   -14     
+ Misses         1973     1965    -8     
  Partials        351      351           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@yangyangv2 yangyangv2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the clean up!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants