Draft
Conversation
nychiang
requested review from
cnpetra,
thartland and
weslleyspereira
and removed request for
weslleyspereira
nychiang
commented
Apr 10, 2026
| return fun(x) | ||
|
|
||
|
|
||
| class MPIEvaluator(Evaluator): |
Collaborator
Author
There was a problem hiding this comment.
@thartland do we still need to have this wrapper?
Collaborator
There was a problem hiding this comment.
The previous purpose of the MPIEvaluator was to have a light wrapper on an MPI EvaluationManager in order that we can just submit tasks to it. If the new EvaluationManager has the functionality of the MPIEvaluator then I don't see why we need the MPIEvaluator. It would be nice though if there was a base Evaluator class that something like the new EvaluationManager would derive from. I'll think more about this.
nychiang
force-pushed
the
new-evaluationmanager-dev
branch
from
12d2f3b to
0d2f30e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopt Weslley's new EavaluationManager.