Open
Conversation
Author
|
IMHO, this version is precise enough. However, if necessary, it can be improved dramatically by the cost of couple more multiply/accumulate instructions. Approximately 1 mul/acc per order of magnitude of error. |
Author
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Different fastSin implementation, without LUT.
Here is couple illustrations. Green is error with linear interpolation on LUT with 512 entries. Red line is error with this implementation. Both are scaled by 2048 for visibility.


This method has much smaller assembly size, since it doesn't require table preparation. Also it is considerably more performant:
PolySin here is the new implementation.

Both basically without actual vectorization, just by virtue of pure and simple computation without retrieving stuff from memory.
Basically it generates triangle wave with sine shaper afterwards. Sine shapers idea is a simple 7-th degree polynomial. Idea of exact polynomial construction was taken from NI Reaktor Core library and recalculated with better precision.