Open
Conversation
ported reaper inject from old private fork which was a mess. added function to WaveSabreConvert to convert a song object into a reaper project file for instruments only added button in project manager so you can use it
yupferris
reviewed
May 13, 2019
Member
yupferris
left a comment
yupferris
left a comment
There was a problem hiding this comment.
This looks great! I have one concern though: the ReaperDevices.rpp file- do we need to update that whenever we add a new device and/or add parameters to existing devices? If so we need to either document that somewhere or perhaps dig in and try to figure out what exactly the extra data is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ported reaper inject from old private fork which was a mess.
added function to WaveSabreConvert to convert a song object into a reaper project file for instruments only
added button in project manager so you can use it