feat(connector): add MailJunky email connector#8638
feat(connector): add MailJunky email connector#8638devadarshh wants to merge 7 commits intologto-io:masterfrom
Conversation
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/connectors/connector-mailjunky/CHANGELOG.md | 📈 +314 Bytes |
| packages/connectors/connector-mailjunky/README.md | 📈 +3.5 KB |
| packages/connectors/connector-mailjunky/logo.svg | |
| packages/connectors/connector-mailjunky/package.json | 📈 +1.73 KB |
| packages/connectors/connector-mailjunky/src/constant.ts | 📈 +4.05 KB |
| packages/connectors/connector-mailjunky/src/html-to-text.d.ts | 📈 +411 Bytes |
| packages/connectors/connector-mailjunky/src/index.test.ts | 📈 +6.14 KB |
| packages/connectors/connector-mailjunky/src/index.ts | 📈 +6.25 KB |
| packages/connectors/connector-mailjunky/src/mock.ts | 📈 +1.54 KB |
| packages/connectors/connector-mailjunky/src/type.test.ts | 📈 +1.09 KB |
| packages/connectors/connector-mailjunky/src/types.ts | 📈 +1.66 KB |
| pnpm-lock.yaml | 📈 +5.74 KB |
|
I noticed that the endpoint mentioned in the issue ( While testing against MailJunky’s current API, the working endpoint was:
I verified this endpoint with real requests and confirmed successful email delivery. The connector implementation and README have been aligned with this working API. Happy to update if there is an official documented endpoint I should follow. |
devadarshh
force-pushed
the
feat/connector-mailjunky
branch
from
db4b266 to
56925d3
Compare
devadarshh
force-pushed
the
feat/connector-mailjunky
branch
from
56925d3 to
933816f
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
wangsijie
left a comment
wangsijie
left a comment
There was a problem hiding this comment.
🤖 PR Review
This PR adds a new MailJunky email connector with templated HTML/plain-text delivery and localized template support.
- 🔒 Security: clean
- 🏗️ Architecture: clean
- 👨💻 Engineering: 0 high, 1 medium
Verdict:
devadarshh
force-pushed
the
feat/connector-mailjunky
branch
from
c9cfc76 to
8d3aba6
Compare
wangsijie
left a comment
wangsijie
left a comment
There was a problem hiding this comment.
🤖 PR Review
This PR adds a MailJunky email connector with localized templating support, and it still needs follow-up on provider error handling while CI is not fully green.
- 🔒 Security: clean
- 🏗️ Architecture: 0 high, 1 medium
- 👨💻 Engineering: clean
Verdict:
|
Hi @devadarshh, could you please sign your commits with GPG key and then force push? |
MailJunky: strip HTML tags until stable for the multipart text part.
Support `sendFrom` templates like "Name <email@domain>". Add coverage for mailbox formatting. Made-with: Cursor
devadarshh
force-pushed
the
feat/connector-mailjunky
branch
from
b0b6d8c to
136cf17
Compare
Hi @wangsijie, I’ve re-signed the commits with my GPG key and force-pushed the branch. All commits should now show Verified (GPG) on GitHub. Thanks! |
4 participants
Summary
This PR adds
@logto/connector-mailjunky, a native Logto email connector for MailJunky. It sends authentication and related emails by calling MailJunky’s HTTP API withAuthorization: Bearer <apiKey>and a JSON body that includesfrom,to,subject,html, andtext, with Handlebars-based templates and i18n template support consistent with other Logto email connectors.The send endpoint used in code and docs is
POST https://mailjunky.ai/api/v1/emails/send. Issue #8257 mentionshttps://api.mailjunky.ai/v1/send; that URL did not match the working JSON API during implementation, so this PR documents the route that returns proper API responses (seeconstant.tsand the connector README).Closes #8257.
Testing
pnpm testinpackages/connectors/connector-mailjunky(Vitest:index.test.ts,type.test.ts).pnpm lintandpnpm buildinpackages/connectors/connector-mailjunky(optional but recommended before push).Checklist
.changesetpackages/integration-testsupdates)