fix(core): allow initial password setup without verification#8746
Open
fix(core): allow initial password setup without verification#8746
Conversation
COMPARE TO
|
| Name | Diff |
|---|---|
| .changeset/initial-password-setup.md | 📉 -167 Bytes |
| packages/account/src/apis/account.ts | 📉 -123 Bytes |
| packages/account/src/pages/Password/index.tsx | 📉 -383 Bytes |
| packages/account/src/utils/security-page.test.ts | 📉 -801 Bytes |
| packages/account/src/utils/security-page.ts | 📉 -214 Bytes |
| packages/console/src/pages/SignInExperience/PageContent/SignUpAndSignIn/SignUpForm/SignUpProfileFieldsEditBox/SignUpProfileFieldItem.module.scss | 📉 -476 Bytes |
| packages/console/src/pages/SignInExperience/PageContent/SignUpAndSignIn/SignUpForm/SignUpProfileFieldsEditBox/SignUpProfileFieldItem.tsx | 📉 -685 Bytes |
| packages/console/src/pages/SignInExperience/PageContent/SignUpAndSignIn/SignUpForm/SignUpProfileFieldsEditBox/index.module.scss | 📉 -287 Bytes |
| packages/console/src/pages/SignInExperience/PageContent/SignUpAndSignIn/SignUpForm/SignUpProfileFieldsEditBox/index.tsx | 📉 -4.63 KB |
| packages/console/src/pages/SignInExperience/PageContent/SignUpAndSignIn/SignUpForm/index.tsx | 📉 -317 Bytes |
| packages/console/src/pages/SignInExperience/PageContent/utils/parser.test.ts | 📉 -1.32 KB |
| packages/console/src/pages/SignInExperience/PageContent/utils/parser.ts | 📉 -759 Bytes |
| packages/console/src/pages/SignInExperience/types.ts | 📉 -498 Bytes |
| packages/core/src/routes/account/index.openapi.json | 📉 -199 Bytes |
| packages/core/src/routes/account/index.ts | 📉 -328 Bytes |
| packages/integration-tests/src/api/my-account.ts | 📉 -68 Bytes |
| packages/integration-tests/src/tests/api/account/initial-password-setup.test.ts | 📉 -5.08 KB |
| packages/phrases/src/locales/ar/translation/admin-console/sign-in-exp/sign-up-and-sign-in.ts | 📉 -338 Bytes |
| packages/phrases/src/locales/de/translation/admin-console/sign-in-exp/sign-up-and-sign-in.ts | 📉 -252 Bytes |
| packages/phrases/src/locales/en/translation/admin-console/sign-in-exp/sign-up-and-sign-in.ts | 📉 -235 Bytes |
| packages/phrases/src/locales/es/translation/admin-console/sign-in-exp/sign-up-and-sign-in.ts | 📉 -262 Bytes |
| packages/phrases/src/locales/fr/translation/admin-console/sign-in-exp/sign-up-and-sign-in.ts | 📉 -275 Bytes |
| packages/phrases/src/locales/it/translation/admin-console/sign-in-exp/sign-up-and-sign-in.ts | 📉 -247 Bytes |
| packages/phrases/src/locales/ja/translation/admin-console/sign-in-exp/sign-up-and-sign-in.ts | 📉 -322 Bytes |
| packages/phrases/src/locales/ko/translation/admin-console/sign-in-exp/sign-up-and-sign-in.ts | 📉 -268 Bytes |
| packages/phrases/src/locales/pl-pl/translation/admin-console/sign-in-exp/sign-up-and-sign-in.ts | 📉 -248 Bytes |
| packages/phrases/src/locales/pt-br/translation/admin-console/sign-in-exp/sign-up-and-sign-in.ts | 📉 -261 Bytes |
| packages/phrases/src/locales/pt-pt/translation/admin-console/sign-in-exp/sign-up-and-sign-in.ts | 📉 -264 Bytes |
| packages/phrases/src/locales/ru/translation/admin-console/sign-in-exp/sign-up-and-sign-in.ts | 📉 -329 Bytes |
| packages/phrases/src/locales/th/translation/admin-console/sign-in-exp/sign-up-and-sign-in.ts | 📉 -397 Bytes |
| packages/phrases/src/locales/tr-tr/translation/admin-console/sign-in-exp/sign-up-and-sign-in.ts | 📉 -251 Bytes |
| packages/phrases/src/locales/zh-cn/translation/admin-console/sign-in-exp/sign-up-and-sign-in.ts | 📉 -246 Bytes |
| packages/phrases/src/locales/zh-hk/translation/admin-console/sign-in-exp/sign-up-and-sign-in.ts | 📉 -258 Bytes |
| packages/phrases/src/locales/zh-tw/translation/admin-console/sign-in-exp/sign-up-and-sign-in.ts | 📉 -258 Bytes |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a9ac01a94f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow Account API users who have no password, primary email, or primary phone to set their first password without a
logto-verification-id.This keeps verification required for users who already have password, primary email, or primary phone, and keeps the relaxation scoped to
POST /api/my-account/password. Account Center now skips the empty verification method screen for zero-method users and sends the password update request without the verification header only in that initial setup path.Also updates the Account API OpenAPI description and adds a changeset.
Design doc
https://www.notion.so/silverhand/Allow-initial-password-setup-without-prior-verification-35026f6af1dc818c9a4be2f689c5bd8e
Testing
Integration tests
Checklist
.changeset