Skip to content

feat: add functionality to delete and hide empty root containers#708

Merged
zxch3n merged 5 commits into
mainfrom
feat-delete-root-container
Apr 8, 2025
Merged

feat: add functionality to delete and hide empty root containers#708
zxch3n merged 5 commits into
mainfrom
feat-delete-root-container

Conversation

@zxch3n
Copy link
Copy Markdown
Member

@zxch3n zxch3n commented Apr 8, 2025

Resolve #682

  • Implemented delete_root_container method to remove content from root containers and hide them from document snapshots.
  • Added set_hide_empty_root_containers method to control visibility of empty root containers.
  • Updated tests to verify the new functionality for deleting and hiding root containers.
  • Enhanced LoroValue with is_empty_collection method to check for empty collections.

zxch3n added 3 commits April 8, 2025 16:03
- Implemented `delete_root_container` method to remove content from root containers and hide them from document snapshots.
- Added `set_hide_empty_root_containers` method to control visibility of empty root containers.
- Updated tests to verify the new functionality for deleting and hiding root containers.
- Enhanced `LoroValue` with `is_empty_collection` method to check for empty collections.
@zxch3n zxch3n requested review from Leeeon233 and Copilot and removed request for Copilot April 8, 2025 08:06
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

Comment thread crates/loro-internal/src/loro.rs Outdated
zxch3n and others added 2 commits April 8, 2025 16:18
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@zxch3n zxch3n merged commit bf94a03 into main Apr 8, 2025
1 check passed
@zxch3n zxch3n deleted the feat-delete-root-container branch April 8, 2025 10:28
@github-actions github-actions Bot mentioned this pull request Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add an option to hide root containers when they are empty

2 participants