Skip to content

fix: add missing PUT, DELETE, PATCH, HEAD, OPTIONS methods to Curl client#40671

Open
lbajsarowicz wants to merge 1 commit intomagento:2.4-developfrom
lbajsarowicz:fix/39330-curl-missing-http-methods
Open

fix: add missing PUT, DELETE, PATCH, HEAD, OPTIONS methods to Curl client#40671
lbajsarowicz wants to merge 1 commit intomagento:2.4-developfrom
lbajsarowicz:fix/39330-curl-missing-http-methods

Conversation

@lbajsarowicz
Copy link
Copy Markdown
Contributor

@lbajsarowicz lbajsarowicz commented Apr 9, 2026

Summary

Adds missing standard HTTP methods to Magento\Framework\HTTP\Client\Curl:

  • put($uri, $params)
  • delete($uri, $params)
  • patch($uri, $params)
  • head($uri)
  • options($uri)

Related: #39330, #39469 (both closed without merge)

Problem

The Curl HTTP client only supports GET and POST, forcing developers to drop down to raw cURL or use third-party HTTP clients for standard REST operations like PUT, DELETE, and PATCH.

Changes

  • Added five new public methods to Curl.php following the existing get()/post() pattern
  • All methods delegate to the existing makeRequest() which already handles arbitrary HTTP methods via CURLOPT_CUSTOMREQUEST
  • Added unit tests for each new method
  • No interface changes (backward compatible)

Test plan

  • Unit tests pass: vendor/bin/phpunit lib/internal/Magento/Framework/HTTP/Test/Unit/Client/CurlTest.php
  • Static analysis: vendor/bin/phpcs --standard=Magento2 passes on changed files
  • Integration: verify Curl client works for PUT/DELETE/PATCH requests against a test endpoint

⭐ Support my work

Do you like the fix? Remember to react with "👍🏻" to get it merged faster,
Then Sponsor me on Github so I can spend more time on fixing issues like this one.

Learn more at https://github.com/sponsors/lbajsarowicz

Resolved issues:

  1. resolves [Issue] fix: add missing PUT, DELETE, PATCH, HEAD, OPTIONS methods to Curl client #40759: fix: add missing PUT, DELETE, PATCH, HEAD, OPTIONS methods to Curl client

…url client

The Curl HTTP client only supported GET and POST methods, forcing
developers to use raw cURL for other standard HTTP methods. This adds
the missing methods following the same pattern as existing get()/post().
@m2-assistant
Copy link
Copy Markdown

m2-assistant Bot commented Apr 9, 2026

Hi @lbajsarowicz. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@lbajsarowicz
Copy link
Copy Markdown
Contributor Author

@magento run all tests

@engcom-Dash
Copy link
Copy Markdown
Contributor

@magento create issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: P3 May be fixed according to the position in the backlog. Progress: pending review

Projects

Status: Pending Review

Development

Successfully merging this pull request may close these issues.

[Issue] fix: add missing PUT, DELETE, PATCH, HEAD, OPTIONS methods to Curl client

2 participants