Skip to content

Add new VULCAN instrument geometry#41243

Open
peterfpeterson wants to merge 1 commit intomantidproject:mainfrom
peterfpeterson:idf_vulcan
Open

Add new VULCAN instrument geometry#41243
peterfpeterson wants to merge 1 commit intomantidproject:mainfrom
peterfpeterson:idf_vulcan

Conversation

@peterfpeterson
Copy link
Copy Markdown
Member

@peterfpeterson peterfpeterson commented Apr 16, 2026

This is the new IDF for VULCAN in spring 2026. Luc created it and I have tested it.

There is no associate issue, but this is associated with EWM15052

To test:

LoadEventNexus with VULCAN_260112.nxs.h5, then reload the file (to a different workspace) with LoadNexusInstrumentXML=False to get the IDF from this file.


Reviewer

Your comments will be used as part of the gatekeeper process. Comment clearly on what you have checked and tested during your review. Provide an audit trail for any changes requested.

As per the review guidelines:

  • Is the code of an acceptable quality? (Code standards/GUI standards)
  • Has a thorough functional test been performed? Do the changes handle unexpected input/situations?
  • Are appropriately scoped unit and/or system tests provided?
  • Do the release notes conform to the guidelines and describe the changes appropriately?
  • Has the relevant (user and developer) documentation been added/updated?
  • If the PR author isn’t in the mantid-developers or mantid-contributors teams, add a review comment rerun ci to authorize/rerun the CI

Gatekeeper

As per the gatekeeping guidelines:

  • Has a thorough first line review been conducted, including functional testing?
  • At a high-level, is the code quality sufficient?
  • Are the base, milestone and labels correct?

@peterfpeterson peterfpeterson added this to the Release 6.16 milestone Apr 16, 2026
@peterfpeterson peterfpeterson added Diffraction Issues and pull requests related to diffraction Powder Issues and pull requests related to powder diffraction labels Apr 16, 2026
@lldj15
Copy link
Copy Markdown

lldj15 commented Apr 16, 2026

Looks fine

@peterfpeterson peterfpeterson marked this pull request as ready for review April 16, 2026 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Diffraction Issues and pull requests related to diffraction Powder Issues and pull requests related to powder diffraction

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants