feat(base-token): automatic fetching#187
Open
fborello-lambda wants to merge 2 commits intomatter-labs:mainfrom
Open
feat(base-token): automatic fetching#187fborello-lambda wants to merge 2 commits intomatter-labs:mainfrom
fborello-lambda wants to merge 2 commits intomatter-labs:mainfrom
Conversation
ed38a20 to
7a26484
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What ❔
Provide a way to track the Base and ETH tokens.
Why ❔
Maybe the blockExplorerApi is not set and the tokens are not specified in the config file, so if everything fails, ask the RPC for the main tokens.
How to Reproduce ❔
I've created a hyperchain with basetoken, then
npm run hyperchain:createand finally:npm run dev:node:hyperchainNote
I also have a block explorer running but the api is not working, what's the solution for this? or how can i test it out?
If i do:
I get:
{ "items": [], "meta": { "totalItems": 0, "itemCount": 0, "itemsPerPage": 10, "totalPages": 0, "currentPage": 1 }, "links": { "first": "tokens?limit=10&minLiquidity=0", "previous": "", "next": "", "last": "" } }It doesn't even return the base-token address
I've seen that the
mainnetblockExplorerApi doesn't even have this method. How are extra tokens managed? By just looking at the code, seems that the tokens are manually predefined is that the case?