Open
Conversation
Combine the `pqap_stop` and `pqap_start` functions into a single `pqap_restart` function and optimize interface checking. * Replace `ensure_interface_up` and `is_interface_up` functions with a single `check_and_ensure_interface_up` function. * Update `pqap_start` function to use `check_and_ensure_interface_up` instead of `is_interface_up` and `ensure_interface_up`. * Move `check_deps` function to a more appropriate location in the script. * Update main function to call `pqap_restart` instead of `pqap_start`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/pqcrypto-vpn?shareId=XXXX-XXXX-XXXX-XXXX).
|
@Kohart please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combine the
pqap_stopandpqap_startfunctions into a singlepqap_restartfunction and optimize interface checking.ensure_interface_upandis_interface_upfunctions with a singlecheck_and_ensure_interface_upfunction.pqap_startfunction to usecheck_and_ensure_interface_upinstead ofis_interface_upandensure_interface_up.check_depsfunction to a more appropriate location in the script.pqap_restartinstead ofpqap_start.For more details, open the Copilot Workspace session.