Conversation
…r improved security
…abase existence check and creation logic.
… update related functions
jestradaMS
added
Schema Version unchanged
No-PaaS-breaking-change
No-ADR
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5477 +/- ##
=======================================
Coverage ? 77.02%
=======================================
Files ? 979
Lines ? 35717
Branches ? 5368
=======================================
Hits ? 27510
Misses ? 6874
Partials ? 1333 🚀 New features to boost your workflow:
|
…ages in PR pipeline
…Bicep template, and create common Bicep module for shared resources
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Can you post an example of the working sample aca code @jestradaMS? |
There was a problem hiding this comment.
Since ACA is the way we are executing test moving forward, do we really need the -aca suffix on the file name?
| $additionalProperties["FhirServer__CoreFeatures__SearchParameterCacheRefreshIntervalSeconds"] = 2 | ||
| $additionalProperties["ASPNETCORE_FORWARDEDHEADERS_ENABLED"] = "true" | ||
|
|
||
| $staticEnvNames = @( |
There was a problem hiding this comment.
Is this approach (array of config values) expandable as we add more configuration to our application?
| $additionalProperties["FhirServer__CoreFeatures__SearchParameterCacheRefreshIntervalSeconds"] = 2 | ||
| $additionalProperties["ASPNETCORE_FORWARDEDHEADERS_ENABLED"] = "true" | ||
|
|
||
| $staticEnvNames = @( |
There was a problem hiding this comment.
Can we share some common code with SQL in this script?
|
3 participants
Description
This pull request introduces support for deploying and testing to Azure Container Apps (ACA) managed environments across PR, CI and export pipelines. The main changes include defining new variables for ACA, adding a dedicated pipeline stage to create the ACA managed environment, updating deployment and test job templates to target ACA, and ensuring consistent use of the correct resource group and key vault variables.
These changes collectively enable the pipelines to deploy to and test against Azure Container Apps, improving support for containerized workloads and aligning with modern Azure deployment practices.
Related issues
Addresses AB#181187.
Testing
Describe how this change was tested.
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)