Skip to content

initial Migration guide#1574

Merged
gdams merged 9 commits into
microsoft/mainfrom
dev/gadams/migration
Sep 12, 2025
Merged

initial Migration guide#1574
gdams merged 9 commits into
microsoft/mainfrom
dev/gadams/migration

Conversation

@gdams
Copy link
Copy Markdown
Member

@gdams gdams commented Mar 4, 2025

Draft for now as this will need some more improvements before it's ready for prime-time

Preview: https://github.com/microsoft/go/blob/dev/gadams/migration/eng/doc/MigrationGuide.md

@dagood
Copy link
Copy Markdown
Member

dagood commented Mar 6, 2025

FWIW, my biases about this kind of doc have me skeptical. I think the intended audience of the doc (i.e. its purpose) needs to be well defined and narrow, and it's important not to accumulate duplicates of information that is (or should be) described better elsewhere. I don't know if any notes about FIPS even belong here, only at most describing how to turn on systemcrypto given the audience is (I imagine) internal Microsoft devs.

@gdams gdams force-pushed the dev/gadams/migration branch from 5ba452f to 447189b Compare August 20, 2025 12:15
@gdams
Copy link
Copy Markdown
Member Author

gdams commented Aug 20, 2025

@dagood I took another pass at this document focussing far more on a high-level user reading the docs and using this doc as an entry point to funnel users to the correct information. LMKWYT

@gdams gdams requested a review from dagood August 20, 2025 20:39
@gdams gdams marked this pull request as ready for review August 20, 2025 20:40
@gdams gdams requested a review from a team as a code owner August 20, 2025 20:40
Copy link
Copy Markdown
Member

@dagood dagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of a review pass, but I'm not sure it's gotten focused enough overall.

Comment thread eng/doc/MigrationGuide.md Outdated
Comment thread eng/doc/MigrationGuide.md Outdated
Comment thread eng/doc/MigrationGuide.md Outdated
Comment thread eng/doc/MigrationGuide.md Outdated
Comment thread eng/doc/MigrationGuide.md Outdated
Comment thread eng/doc/MigrationGuide.md Outdated
Comment thread eng/doc/MigrationGuide.md Outdated
Comment thread eng/doc/MigrationGuide.md Outdated
Comment thread eng/doc/MigrationGuide.md Outdated
Comment thread eng/doc/MigrationGuide.md Outdated
@dagood
Copy link
Copy Markdown
Member

dagood commented Sep 3, 2025

I tried a pass to rearrange/cut it in a way I'm happier with it (hard to know if I'm nudging in a direction that actually ends up somewhere I like), and this is where I got: dev/gadams/migration...dagood:go:dev/dagood/migration-guide-wip. In general, fewer types of sections, let the readme do its job, focus very tightly on migrating the user from where they are.

@gdams
Copy link
Copy Markdown
Member Author

gdams commented Sep 9, 2025

I tried a pass to rearrange/cut it in a way I'm happier with it (hard to know if I'm nudging in a direction that actually ends up somewhere I like), and this is where I got: dev/gadams/migration...dagood:go:dev/dagood/migration-guide-wip. In general, fewer types of sections, let the readme do its job, focus very tightly on migrating the user from where they are.

I like it, I've cherry-picked your changes onto this branch

@karianna karianna requested a review from dagood September 10, 2025 02:44
@dagood
Copy link
Copy Markdown
Member

dagood commented Sep 11, 2025

Re: nosystemcrypto and:

We probably shouldn't mention it in this doc then! (Intentionally opinionated statement to discuss. 🙂)

I think perhaps this just needs a clear warning attached to it?

In a quick guide I think that we should acknowledge the errors that can happen as a result of systemcrypto and only mention opting out in that context, if at all. Perhaps instead of mentioning it inline, we only link to the advanced doc for more information about what opting out is and how in Microsoft you must have a crypto exception. (Not just a broad warning or lack of recommendation.)

Changing approach here. I think we do recommend it as long as the situation is right. Not so much a warning, but rather being very clear about when it should be used.

Copy link
Copy Markdown
Member

@qmuntal qmuntal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this new docs a lot!

@gdams
Copy link
Copy Markdown
Member Author

gdams commented Sep 12, 2025

I like this new docs a lot!

Likewise, I'm concious of this PR growing further so I'm going to hit merge for now and we can make follow-up PR changes if and when required

@gdams gdams enabled auto-merge (squash) September 12, 2025 08:37
@gdams gdams merged commit 0dabf4a into microsoft/main Sep 12, 2025
33 checks passed
@gdams gdams deleted the dev/gadams/migration branch September 12, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants