Rework parser: eager cache, hinted scan, wstring_view#276
Open
kylereedmsft wants to merge 1 commit intomicrosoft:masterfrom
Open
Rework parser: eager cache, hinted scan, wstring_view#276kylereedmsft wants to merge 1 commit intomicrosoft:masterfrom
kylereedmsft wants to merge 1 commit intomicrosoft:masterfrom
Conversation
Member
kylereedmsft
commented
Apr 6, 2026
- Replace lazy deque cache with vector<property_info> fully populated on first access (ensure_cache_populated)
- Add hinted linear scan for name->index resolution; sequential access is O(1) per call, callers can also provide explicit hints
- Add parse/try_parse/view_of overloads accepting a ULONG hint parameter
- Convert all property name parameters from const std::wstring& to std::wstring_view to avoid temporary allocations
- Chain no-hint overloads to hint versions to eliminate code duplication
24e2247 to
b73cfdf
Compare
Merged
Member
Author
|
We decided that for our normal use cases (sparse access), eager caching adds more overhead even though it's better for full record access. We're going with #275 instead which includes the hinting from this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.