inlineChat: fix model picker overflow when selecting Auto#309427
Merged
inlineChat: fix model picker overflow when selecting Auto#309427
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an inline chat (v2) layout regression where selecting the short “Auto” label caused the model picker to be pushed into the toolbar overflow menu by ensuring the input toolbar has a stable, container-based width in the chat-attachments-container layout.
Changes:
- Set
width: 100%on.chat-attachments-container > .chat-input-toolbarin inline chat v2 styling to prevent content-based shrinking that triggers responsive overflow.
Show a summary per file
| File | Description |
|---|---|
src/vs/workbench/contrib/inlineChat/browser/media/inlineChat.css |
Ensures the inline chat v2 input toolbar takes the full available width to avoid model picker collapsing into overflow when label text becomes shorter. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
sandy081
approved these changes
Apr 13, 2026
jrieken
added
the
~release-cherry-pick
vs-code-engineering
Bot
added
release-cherry-pick
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #309424
When selecting the "Auto" model in the inline chat model picker, the picker would collapse into the toolbar overflow menu ("..."). This happened because the toolbar element lacked a fixed width - its width was content-based and shrank when switching to a shorter label like "Auto", causing the responsive overflow logic to hide it.
Session Context
Key decisions from the development session:
renderInputToolbarBelowInputis true (inline chat v2), the toolbar is placed in.chat-attachments-containerinstead of.chat-input-toolbars. The CSS rule.chat-input-toolbars > .chat-input-toolbar { width: 100% }doesn't match because the parent element is different. Withoutwidth: 100%, the toolbar width is content-based and shrinks when the model label changes. TheResizeObserveron the toolbar fires with the smaller width, and the responsive overflow logic intoolbar.ts#updateActions()decides items need to be hidden.width: 100%to the existing.chat-attachments-container > .chat-input-toolbarrule in the inline chat v2 CSS block, matching the behavior of the normal chat layout.minimumWidth > containerWidth, triggering overflow. Longer model names keep the toolbar wide enough to avoid this threshold.Changes
width: 100%to.chat-attachments-container > .chat-input-toolbarin the inline chat v2 CSS block so the toolbar takes the full container width regardless of label content length.