Two Skills#4
Closed
naitik-mixpanel wants to merge 7 commits intomixpanel:mcp-launchfrom
Closed
Conversation
Comment on lines
+94
to
+95
| For events: `Edit-Event(project_id, event_name, display_name, description)` | ||
| For properties: `Edit-Property(project_id, property_name, resource_type, display_name, description)` |
There was a problem hiding this comment.
This is fine for the moment, but we may want to update this after we add capabilities to update descriptions and display name support to Bulk-Edit-Events and Bulk-Edit-Properties
kenshermanmxpnl
approved these changes
Apr 16, 2026
Re-thought of metric diagnosis skill
What changed
Property metadata writes (description, display_name) now use Bulk-Edit-Properties instead of looping per-call Edit-Property. Mixpanel's MCP surface was extended to expose per-entry description and display_name on Bulk-Edit-Properties, making the previous per-call fallback unnecessary.
Why
The skill was written against an older Bulk-Edit-Properties schema that only supported uniform fields (tags, hidden, dropped, sensitive). That forced the enrich and reset flows to fall back to per-property Edit-Property calls in batches of 10 — a real throughput bottleneck on property-heavy projects.
Files touched
FileChangeSKILL.mdRemoved the "Bulk-Edit-Properties does NOT support description/display_name" clause in Rule 8. Restated the per-call batching rule to cover only tag CRUD and failure-path Edit-* fallbacks.commands/enrich-and-tag.mdRewrote Step 4d. Property metadata writes now go through Bulk-Edit-Properties in chunks of 50, split by resource_type. Header blurb updated (properties no longer "per-call").commands/reset-lexicon.mdRewrote Step 4c. Clearing property descriptions/display names now uses Bulk-Edit-Properties with empty-string entries, chunks of 50, split by resource_type.README.mdAdded Apr 2026 changelog entry.
Implementation notes
Split by resource_type. Bulk-Edit-Properties accepts one resource_type per call (Event or User). Both rewritten flows now partition property gaps by type and issue separate bulk calls. In practice this is one or two calls per project, not ten-plus.
Failure fallback preserved. If a bulk chunk fails, the flow falls back to per-property Edit-Property for that chunk only, logs, and continues. No single failure aborts the batch.
Tag payload shape unchanged. Already using the current { names: [...], operation: "set"|"add"|"remove" } object shape — no fix needed.
Fill-only-empty guarantee preserved. Each bulk entry still includes only the fields that were empty pre-write; existing metadata is never clobbered.
Expected impact
On a project with ~100 property metadata gaps: ~10 sequential Edit-Property calls → 2 Bulk-Edit-Properties calls (one per resource type). Roughly 5× fewer round trips, and a larger wall-clock improvement since each per-call write had its own latency overhead.
Not included in this PR
No changes to command menu, preview tables, confirmation prompts, or final output formats.
No changes to exclusions, fill-only-empty logic, or session cache handling.
No changes to score-lexicon, review-issues, or manage-tags.
Testing
Manual verification recommended on a staging or low-stakes project:
Run Enrich & Tag on a project with property metadata gaps across both Event and User properties → confirm two bulk calls are issued and progress output reads Properties: N/N metadata updated.
Run Reset Lexicon selecting property descriptions and display names → confirm clearing works across both resource types.
Induce a bulk-call failure (e.g. invalid property name in the chunk) → confirm per-chunk fallback to Edit-Property engages and the flow continues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding 2 customer facing skills