Implement path traversal protection in MJML includes#3065
Open
zdods wants to merge 1 commit intomjmlio:masterfrom
Open
Implement path traversal protection in MJML includes#3065zdods wants to merge 1 commit intomjmlio:masterfrom
zdods wants to merge 1 commit intomjmlio:masterfrom
Conversation
- Added security checks to prevent relative and absolute path traversal in `mj-include` tags, ensuring included files are within the project directory. - Introduced a new helper function `assertPathWithinRoot` to validate file paths. - Updated documentation to reflect the new security measures. - Added tests to verify the enforcement of these security rules and ensure error messages do not leak filesystem paths.
zdods
force-pushed
the
fix/CVE-2020-12827
branch
from
e2bd3d9 to
3748c64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mj-includetags, ensuring included files are within the project directory.assertPathWithinRootto validate file paths.