Add token support#49
Open
SDonkelaarGDD wants to merge 1 commit intomlflow:masterfrom
Open
Conversation
…r tokens in environment variables. Signed-off-by: Sander van Donkelaar <sandervandonkelaar@godatadriven.com>
SDonkelaarGDD
force-pushed
the
support_tracking_token
branch
from
6feac8d to
29493bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes:
I changed the function
get_mlflow_host_token()in the modulemlflow_utils.py, such that it loads a tracking token if it's found in the in environment variables.The fix required only a very small change. The function
_mk_headers()in the modulehttp_client.pyis already written in such a way that it automatically sets the tracking token if present, so no changes are further necessary.Motivation:
We want to use
mlflow-export-importto migrate models between OOS tracking servers in an enterprise setting (at a bank). However, since our tracking servers are both behind oauth2 proxies, support for bearer tokens is essential for us to make it work. I decided to make a PR because it can also be useful to others.