Make Feed keep and expose a reference to the original feed object#235
Open
infogulch wants to merge 1 commit intommcdole:masterfrom
Open
Make Feed keep and expose a reference to the original feed object#235infogulch wants to merge 1 commit intommcdole:masterfrom
infogulch wants to merge 1 commit intommcdole:masterfrom
Conversation
Call Feed.OriginalFeed() to get the original feed if available.
Contributor
Author
|
Ah of course the test expected values don't match anymore. Not sure if the expected values should be updated or if the tests should ignore the originalFeed field since it's not exposed anyway. |
Contributor
Author
|
A different implementation could change the definition of Translate() to return three values: the general |
This was referenced May 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Call Feed.OriginalFeed() to get the original feed if available.
Fixes #229
I just threw this together real quick to see what you think about it.