Skip to content

Develop#408

Merged
yama merged 17 commits intomainfrom
develop
Apr 26, 2026
Merged

Develop#408
yama merged 17 commits intomainfrom
develop

Conversation

@yama
Copy link
Copy Markdown
Member

@yama yama commented Apr 26, 2026

This pull request adds detailed ExecPlan specification documents under .agent/plans for a multi-phase REST API and management interface modernization project. These documents outline the architecture, step-by-step implementation plans, validation criteria, and dependencies for building a robust API router, security/authentication layers, headless read APIs, write APIs for management, admin URL migration, and the retirement of legacy endpoints. Additionally, the ExecPlan archival policy is updated to improve plan lifecycle management.

Key changes:

ExecPlan Documentation for API Modernization

  • Added .agent/plans/2026-02-14-api-router-foundation.md: Specifies the foundational API router, including route registration, dispatch logic, namespace resolution, and fallback mechanisms for both pretty and fallback URLs.
  • Added .agent/plans/2026-02-14-rest-api-foundation-security.md: Details the REST API security layer, covering authentication (Bearer token, session+nonce), replay protection, rate limiting, unified error handling, and logging.
  • Added .agent/plans/2026-02-14-headless-read-api.md: Outlines the headless public read API, including resource/media endpoints, paging, field selection, and information leakage prevention.
  • Added .agent/plans/2026-02-14-manager-write-api.md: Defines the management write API for resource CRUD and publish/unpublish actions, with strict permission and audit requirements.
  • Added .agent/plans/2026-02-14-manager-url-routing-migration.md: Describes the migration to a configurable admin URL prefix (manager_prefix), with fallback and compatibility strategies.
  • Added .agent/plans/2026-02-14-manager-public-endpoint-retirement.md: Plans the phased retirement of the public manager/ endpoint, including compatibility, monitoring, and rollback strategies.

Process and Policy Updates

  • Updated .agent/PLANS.md to require completed ExecPlans to be moved to .agent/plans/archive/, with filenames updated to the completion date and roadmap references updated accordingly.
  • Updated .agent/roadmap.md to the fixed Status/date/ExecPlan template and aligned the newly added tasks with that format.

Codex Skill Workflow Updates

  • Added and updated .codex/skills/* workflows for ExecPlan creation, roadmap management, next-task selection, and issue resolution.
  • Aligned roadmap-related skill prompts with the Status: NEXT/WIP/DONE/BLOCKED format and completion-date synchronization rules.

Docker Development Environment

  • Added a local Docker Compose development environment with PHP 8.4 Apache, MySQL 8.3, and Mailpit.
  • Added manager/docker/Dockerfile, php.ini, and msmtprc for reproducible local startup.
  • Hardened the Docker defaults by using environment-variable-backed DB credentials, removing committed shell history, disabling display_errors, enabling PHP error logging, and cleaning apt metadata in the image layer.

These changes provide a comprehensive, stepwise roadmap for evolving the API and management architecture with clear separation of concerns, robust security, maintainable migration paths, and a documented local development environment.

yama added 8 commits February 14, 2026 19:48
- Added initial API router structure in `api.php` to handle routing for `/api/v1/...` endpoints.
- Established a unified JSON response format and routing mechanism with fallback for non-rewrite environments.
- Introduced multi-layer authentication: anonymous access for public GET requests and required authentication for write operations.
- Implemented Bearer opaque token and session nonce authentication methods, along with replay attack prevention using timestamps and nonces.
- Set up rate limiting based on IP and API key, returning 429 responses when limits are exceeded.
- Integrated audit logging for security events and standardized error responses across the API.
- Created detailed plans for headless read API, manager write API, and phased retirement of legacy public endpoints.
Copilot AI review requested due to automatic review settings April 26, 2026 01:36
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cf5d770754

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .codex/skills/roadmap-next-task/agents/openai.yaml Outdated
Comment thread .agent/roadmap.md
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

API/管理画面モダナイズ計画を ExecPlan 群として .agent/plans 配下に体系化し、ロードマップと ExecPlan の連携・アーカイブ運用をスキル定義と規約で補強する変更。

Changes:

  • API Router / セキュリティ / Headless Read / 管理 Write / 管理URL移行 / manager公開廃止の ExecPlan を追加
  • .agent/roadmap.md を固定テンプレート(Status/日付/ExecPlan 等)前提の記述へ更新
  • ExecPlan アーカイブ方針を .agent/PLANS.md と skill 定義に反映

Reviewed changes

Copilot reviewed 16 out of 17 changed files in this pull request and generated 17 comments.

Show a summary per file
File Description
.codex/skills/roadmap-next-task/agents/openai.yaml 次タスク選定〜着手プロンプト定義を追加
.codex/skills/roadmap-next-task/SKILL.md 次タスク着手スキルの運用ルール・コマンド定義を追加
.codex/skills/roadmap-manager/agents/openai.yaml ロードマップ保守プロンプト定義を追加
.codex/skills/roadmap-manager/SKILL.md ロードマップ固定フォーマットと操作コマンドを定義
.codex/skills/exec-plan/agents/openai.yaml ExecPlan 作成/更新にロードマップ連携・アーカイブ運用を追加
.codex/skills/exec-plan/SKILL.md ロードマップ連携(Status/日付/アーカイブ)を明文化
.agent/roadmap.md ロードマップを固定テンプレート形式へ刷新し ExecPlan 参照を付与
.agent/plans/archive/2026-02-14-outputfilter-undefined-array-key.md アーカイブ済み Plan の進捗・記録を更新
.agent/plans/archive/2026-02-14-logging-paging-undefined-key.md 画面検証完了の反映
.agent/plans/archive/2026-02-11-evo-cli-self-bootstrap.md CLI Self-Bootstrap の ExecPlan をアーカイブとして追加
.agent/plans/2026-02-14-rest-api-foundation-security.md REST API 基盤/認証/制限の ExecPlan を追加
.agent/plans/2026-02-14-manager-write-api.md 管理操作 Write API の ExecPlan を追加
.agent/plans/2026-02-14-manager-url-routing-migration.md 管理画面URL可変化(manager_prefix)の ExecPlan を追加
.agent/plans/2026-02-14-manager-public-endpoint-retirement.md manager 公開URL廃止の ExecPlan を追加
.agent/plans/2026-02-14-headless-read-api.md Headless 公開 Read API の ExecPlan を追加
.agent/plans/2026-02-14-api-router-foundation.md API Router 基盤の ExecPlan を追加
.agent/PLANS.md 完了 ExecPlan の archive 移動・リネーム・ロードマップ更新ルールを追加
Comments suppressed due to low confidence (1)

.agent/plans/archive/2026-02-14-outputfilter-undefined-array-key.md:57

  • 再現性のための実行コマンドが git diff -- <plan-file> のプレースホルダのままで、コピペ実行できない。Plan内の具体パス(このファイルの相対パス)に置き換えて、過去チャット無しで手順を実行できる状態にしてほしい。

Comment thread .agent/roadmap.md
Comment thread .agent/roadmap.md
Comment thread .agent/roadmap.md
Comment thread .agent/roadmap.md
Comment thread .agent/roadmap.md
Comment thread .agent/roadmap.md
Comment thread .agent/roadmap.md
Comment thread .agent/roadmap.md
Comment thread .agent/plans/2026-02-14-rest-api-foundation-security.md Outdated
Comment thread .agent/roadmap.md
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot finished work on behalf of yama April 26, 2026 02:56
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 17 out of 18 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (1)

.agent/plans/archive/2026-02-14-outputfilter-undefined-array-key.md:56

  • git diff -- <plan-file> がプレースホルダのままで、そのままでは検証手順として実行できない。git diff -- .agent/plans/archive/2026-02-14-outputfilter-undefined-array-key.md のように具体パスを記載して再現可能にしたい。

Comment thread compose.yml
Comment thread .agent/roadmap.md Outdated
Comment thread compose.yml
Comment thread compose.yml
Comment thread compose.yml Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 22 out of 23 changed files in this pull request and generated 5 comments.

Comment thread manager/docker/.bash_history Outdated
Comment thread manager/docker/php.ini Outdated
Comment thread compose.yml
Comment thread compose.yml Outdated
Comment thread manager/docker/Dockerfile Outdated
Copilot finished work on behalf of yama April 26, 2026 04:42
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 21 out of 23 changed files in this pull request and generated 4 comments.

Comment thread compose.yml
Comment thread manager/docker/.bashrc
Comment thread compose.yml
Comment thread compose.yml
@yama yama merged commit 1814fee into main Apr 26, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants