Abstract Base Package Name#23
Open
FuzzicalLogic wants to merge 3 commits intomodxcms:masterfrom
FuzzicalLogic:master
Open
Abstract Base Package Name#23FuzzicalLogic wants to merge 3 commits intomodxcms:masterfrom FuzzicalLogic:master
FuzzicalLogic wants to merge 3 commits intomodxcms:masterfrom
FuzzicalLogic:master
Conversation
Sync to Teleport 1.3
Allows for custom names in extended implementations. If it becomes desirable to include naming logic in the library, this will additionally make it easier to do so.
Sample Extension:
class ExtractExtra extends \Teleport\Action\Extract {
protected function getName() {
// No profile prefix
return $this->tpl['name'];
}
}
Abstract out Package Name creation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows for custom names in extended implementations. If it becomes desirable to include naming logic in the library, this will additionally make it easier to do so. The purpose behind this change is to allow for extensions of different types to choose a different naming scheme based on a development/release path. For instance, for an extra, the site profile is not nearly as important as it is for a site backup or transfer.
Sample Extension: