SERVER-120105 Expose pre-TLS trait on listeners#2
Conversation
|
This is heavily inspired by this PR that is yet to be merged in Pingora upstream but was clearly added with the intent of supporting the proxy protocol. I could include proxy protocol changes into our Pingora fork, too, but I figured I might as well keep that within monguard to keep this as close to Pingora upstream as possible. This should be enough for me to build a quick proxy protocol parsing library that a struct implementing |
ryanberryhill
left a comment
ryanberryhill
left a comment
There was a problem hiding this comment.
LGTM. This doesn't need to be discussed here, but I think we should have a plan to upstream things like this if we don't already.
| let addr1 = "127.0.0.1:7107"; | ||
| let addr2 = "127.0.0.1:7108"; |
There was a problem hiding this comment.
Why was this needed?
There was a problem hiding this comment.
When I ran the listener tests locally, this test and this test failed due to port conflicts. I'm not sure exactly where and how Pingora runs these tests internally (e.g., do they make sure they run serially so this doesn't happen?) but I thought I'd just change the ports so that we can run cargo test -p pingora-core without seeing a failure here.
2 participants
No description provided.