Always close typhon response body when present#179
Merged
cstorey-monzo merged 4 commits intomasterfrom Feb 20, 2026
Merged
Conversation
cstorey-monzo
changed the title
milesbxf
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re: #153
We previously didn't close the response body if we weren't going to send a body over the wire. However, this could cause a resource leak when the response body requires a resource that can't be handled by the garbage collector (eg: a goroutine).
This should fix that issue by slightly re-arranging the closure logic.
This changes the indentation slightly, so you'll want to view it ignoring whitespace.