Generate ripoff queries asynchronously to help plugin performance#27
Merged
Generate ripoff queries asynchronously to help plugin performance#27
Conversation
mortenson
commented
Mar 21, 2026
Comment on lines
-62
to
-65
| if r.Type == "exit" { | ||
| os.Exit(0) | ||
| return | ||
| } |
Owner
Author
There was a problem hiding this comment.
This didn't really do anything useful, IMO. Mostly I added it before I had process group IDs working
mortenson
commented
Mar 21, 2026
| return slog.Any("error", err) | ||
| } | ||
|
|
||
| func confirmPluginsSafe(plugins map[string]ripoff.RipoffPlugin) { |
Owner
Author
There was a problem hiding this comment.
This is slightly weird but better than code execution? I would consider this prompt for any ripoff file as well
mortenson
commented
Mar 21, 2026
| rowId string | ||
| query string | ||
| dependencies []string | ||
| err error |
Owner
Author
There was a problem hiding this comment.
I considered errgroup for this but couldn't get it working
Owner
Author
There was a problem hiding this comment.
(or, at least, better than the semaphore)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.