Fix version check#29
Open
thavlik wants to merge 5 commits intomsamogh:masterfrom
Open
Conversation
|
@msamogh this fixes an error which previously was preventing me from using the library. Please consider merging :) |
Author
|
I was lazy and made a few other commits, so this PR needs to be either accepted in full or manually merged. I have been using my fork of nonechucks in my rollouts for over a month now without issues. All of my setup scripts use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am using pytorch
1.6.0+cu101, which excepts on your version check code. The simple fix is to remove the suffix.Thank you!