Performance optimisations for the compartmental feature. (WIP)#1319
Draft
LeanderEwert wants to merge 474 commits intonest:mainfrom
Draft
Performance optimisations for the compartmental feature. (WIP)#1319LeanderEwert wants to merge 474 commits intonest:mainfrom
LeanderEwert wants to merge 474 commits intonest:mainfrom
Conversation
…ompartmental_model_test.py as it creates issues on some systems
Fix compartmental models code generator after printers refactor
…ocessing.py excluding explicitly formulated ODEs from syn_info. State of functionality: Succesfull codegeneration and compilation. Segfault during simulation.
…on synaptic functions dont break synapse models anymore. State of functionality: Almost fully working. Explicitly written ODEs for synapses not supported yet. (next up)
… close to zero to skip calculation of step-function. State of functionality: Almost fully working. Explicitly written ODEs for synapses not supported yet. (next up)
…ion changed to be done by decorators. Concentration mechanism imlplementation and unification of mechanism info collection in progress.
…ion changed to be done by decorators. Concentration mechanism imlplementation and unification of mechanism info collection in progress.
…erEwert # Conflicts: # doc/fig/nestml_clip_art.png # doc/fig/synapse_conceptual.png # pynestml/codegeneration/resources_nest/point_neuron/directives/CommonPropertiesDictionaryReader.jinja2 # pynestml/frontend/frontend_configuration.py # pynestml/frontend/pynestml_frontend.py # pynestml/generated/PyNestMLLexer.py # pynestml/generated/PyNestMLParser.interp # pynestml/generated/PyNestMLParser.py # pynestml/generated/PyNestMLParserVisitor.py # pynestml/utils/messages.py # pynestml/visitors/ast_symbol_table_visitor.py # tests/cocos_test.py
…stem. ToDo: Completing commenting and removing legacy code-parts and inline debugging code.
-Compile warnings fixed. -v_comp nestml state excluded from becoming mechanism state.
-syns_info_enricher structure aligned to other mechanism enrichers. -debugging code removed -antlr4-python3-runtime set to 4.12 (from 4.10) in requirements.txt to remove missmatch warnings.
Co-authored-by: Pooja Babu <75320801+pnbabu@users.noreply.github.com>
…o origin/LeanderEwert_cm_stdp # Conflicts: # tests/nest_compartmental_tests/test__compartmental_stdp.py
# Conflicts: # pynestml/codegeneration/resources_nest_compartmental/cm_neuron/cm_neuroncurrents_@NEURON_NAME@.h.jinja2 # tests/nest_compartmental_tests/test__compartmental_model.py
…/Max() by sympy fixed.
LeanderEwert
temporarily deployed
to
external
GitHub Actions
Inactive
Bencher Report
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various performance optimisations for the cm feature, including streamlined data movement, a more SIMD-friendly variable layout, common sub-expression elimination across multiple expressions, and a more efficient synapse implementation.