Skip to content

Add config active_record_use_table_name#3540

Merged
hannahramadan merged 20 commits intodevfrom
ar_metrics_use_table_name
May 6, 2026
Merged

Add config active_record_use_table_name#3540
hannahramadan merged 20 commits intodevfrom
ar_metrics_use_table_name

Conversation

@hannahramadan
Copy link
Copy Markdown
Contributor

@hannahramadan hannahramadan commented Apr 21, 2026

Introduce new config active_record_use_table_name to use the Active Record model's table name instead of the class name when naming Active Record metrics, which also impacts span and segment names.

closes #3465

@hannahramadan hannahramadan changed the title Introduce new config + pg tests Add config active_record_metrics_use_table_name Apr 21, 2026
@hannahramadan hannahramadan changed the title Add config active_record_metrics_use_table_name Add config active_record_use_table_name Apr 21, 2026
@hannahramadan hannahramadan marked this pull request as ready for review April 27, 2026 18:22
@hannahramadan hannahramadan requested a review from a team as a code owner April 27, 2026 18:22
tannalynn
tannalynn previously approved these changes Apr 29, 2026
Copy link
Copy Markdown
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this! Requesting changes since there's one approval and I want to chat about a few things before merge.

Comment thread lib/new_relic/agent/instrumentation/active_record_helper.rb
Comment thread test/multiverse/suites/active_record/active_record_test.rb Outdated
Comment thread lib/new_relic/agent/instrumentation/active_record_helper.rb
Comment thread lib/new_relic/agent/instrumentation/active_record_helper.rb
Comment thread test/multiverse/suites/active_record/active_record_test.rb Outdated
Comment thread lib/new_relic/agent/instrumentation/active_record_helper.rb
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

SimpleCov Report

Coverage Threshold
Line 93.54% 93%

@hannahramadan hannahramadan merged commit 97ed769 into dev May 6, 2026
79 of 80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create option for alternative Active Record metric naming approach

3 participants