feat: port test_cannot_run_js to CTS

PORTING.md

@@ -49,7 +49,7 @@ Tests covering the engine-specific part of Node-API, defined in `js_native_api.h
 | `8_passing_wrapped`          | Ported ✅  | Easy       |
 | `test_array`                 | Ported ✅  | Easy       |
 | `test_bigint`                | Ported ✅  | Easy       |
-| `test_cannot_run_js`         | Not ported | Medium     |
+| `test_cannot_run_js`         | Ported ✅  | Medium     |
 | `test_constructor`           | Ported ✅  | Medium     |
 | `test_conversions`           | Ported ✅  | Medium     |
 | `test_dataview`              | Not ported | Medium     |

tests/js-native-api/test_cannot_run_js/CMakeLists.txt

@@ -0,0 +1,5 @@
+add_node_api_cts_addon(test_cannot_run_js test_cannot_run_js.c)
+target_compile_definitions(test_cannot_run_js PRIVATE NAPI_VERSION=10)
+
+add_node_api_cts_addon(test_pending_exception test_cannot_run_js.c)
+target_compile_definitions(test_pending_exception PRIVATE NAPI_VERSION=9)

tests/js-native-api/test_cannot_run_js/test.js

@@ -0,0 +1,24 @@
+// Test that `napi_get_named_property()` returns `napi_cannot_run_js` in
+// experimental mode and `napi_pending_exception` otherwise. This test calls
+// the add-on's `createRef()` method, which creates a strong reference to a JS
+// function. When the process exits, it calls all reference finalizers. The
+// finalizer for the strong reference created herein will attempt to call
+// `napi_get_property()` on a property of the global object and will abort the
+// process if the API doesn't return the correct status.
+
+if (napiVersion < 10) skipTest();
+const addon_v8 = loadAddon("test_pending_exception");
+const addon_new = loadAddon("test_cannot_run_js");
+
+function runTests(addon) {
+  addon.createRef(function () {
+    throw new Error("function should not have been called");
+  });
+}
+
+function runAllTests() {
+  runTests(addon_v8);
+  runTests(addon_new);
+}
+
+runAllTests();

tests/js-native-api/test_cannot_run_js/test_cannot_run_js.c

@@ -0,0 +1,66 @@
+#include <js_native_api.h>
+#include "../common.h"
+#include "../entry_point.h"
+#include "stdlib.h"
+
+static void Finalize(napi_env env, void* data, void* hint) {
+  napi_value global, set_timeout;
+  napi_ref* ref = data;
+
+  NODE_API_BASIC_ASSERT_RETURN_VOID(
+      napi_delete_reference(env, *ref) == napi_ok,
+      "deleting reference in finalizer should succeed");
+  NODE_API_BASIC_ASSERT_RETURN_VOID(
+      napi_get_global(env, &global) == napi_ok,
+      "getting global reference in finalizer should succeed");
+  napi_status result =
+      napi_get_named_property(env, global, "setTimeout", &set_timeout);
+
+  // The finalizer could be invoked either from check callbacks (as native
+  // immediates) if the event loop is still running (where napi_ok is returned)
+  // or during environment shutdown (where napi_cannot_run_js or
+  // napi_pending_exception is returned). This is not deterministic from
+  // the point of view of the addon.
+
+#if NAPI_VERSION > 9
+  NODE_API_BASIC_ASSERT_RETURN_VOID(
+      result == napi_cannot_run_js || result == napi_ok,
+      "getting named property from global in finalizer should succeed "
+      "or return napi_cannot_run_js");
+#else
+  NODE_API_BASIC_ASSERT_RETURN_VOID(
+      result == napi_pending_exception || result == napi_ok,
+      "getting named property from global in finalizer should succeed "
+      "or return napi_pending_exception");
+#endif  // NAPI_VERSION > 9
+  free(ref);
+}
+
+static napi_value CreateRef(napi_env env, napi_callback_info info) {
+  size_t argc = 1;
+  napi_value cb;
+  napi_valuetype value_type;
+  napi_ref* ref = malloc(sizeof(*ref));
+  NODE_API_CALL(env, napi_get_cb_info(env, info, &argc, &cb, NULL, NULL));
+  NODE_API_ASSERT(env, argc == 1, "Function takes only one argument");
+  NODE_API_CALL(env, napi_typeof(env, cb, &value_type));
+  NODE_API_ASSERT(
+      env, value_type == napi_function, "argument must be function");
+  NODE_API_CALL(env, napi_add_finalizer(env, cb, ref, Finalize, NULL, ref));
+  return cb;
+}
+
+EXTERN_C_START
+napi_value Init(napi_env env, napi_value exports) {
+  napi_property_descriptor properties[] = {
+      DECLARE_NODE_API_PROPERTY("createRef", CreateRef),
+  };
+
+  NODE_API_CALL(
+      env,
+      napi_define_properties(
+          env, exports, sizeof(properties) / sizeof(*properties), properties));
+
+  return exports;
+}
+EXTERN_C_END