Do not set status-style when disabling the nord statusline#64
Open
0phoff wants to merge 1 commit intonordtheme:developfrom
Open
Do not set status-style when disabling the nord statusline#640phoff wants to merge 1 commit intonordtheme:developfrom
0phoff wants to merge 1 commit intonordtheme:developfrom
Conversation
Contributor
|
Hi @0phoff 👋, thanks for your contribution 👍 |
Contributor
|
@0phoff Thanks for your patience, it's been busy times again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commits fixes the code to not set the
status-styleoption when disabling the nord-tmux status-bar.Usually, when disabling the status-bar, it means a user wants to customize it to his/her liking.
For some reason, overriding this
status-styleoption before creating your own bar does not seem to work.The only way I got things working was to explicitly remove that option from your code.
By setting this option in the
nord-status-content.confandnord-status-content-no-patched-font.conffiles, we ensure it gets only set when a user actually uses the provided status-bars.