Add llvmlite usage example python notebook#1192
Conversation
|
@yashssh can you rebase this? Seems like there has not been a review, so rebase is fine. Looks like the CI fail is stale in comp. to |
69eb06e to
93dfc21
Compare
Done |
|
@yashssh Is this still a draft, or ready for a review? |
Some of the examples in the notebook need LLVM19(I created this mainly for my EuroLLVM 2025 presentation). If that's okay I can mark it ready for review. |
|
I think that's OK - I think we can review it independently of the LLVM 19 support, and merge it with / after the LLVM 19 support is merged so we're consistent. |
|
I took a look at this and would like to propose the following patch: This makes two changes to the source code example: a) use And then I reversed the order of running to have the slow variant run first. I believe this is more natural ordering and makes it easier to see the acceleration. I choose to post a patch here, wasn't quite sure how to use the github interface to propose a diff otherwise -- let me know if I should submit it via any other format. |
esc
left a comment
There was a problem hiding this comment.
Added a proposal to modify the introduction.
93dfc21 to
d105be5
Compare
|
Thanks for the review @esc! I have applied your suggestion and have also rebased the patch on top of main. |
No worries, I will continue to review this. Unfortunately I may have suggested to use |
|
No worries, have fixed it |
|
@yashssh thank you again for fixing this, my review continues. I think the Jupyter notebook should start with a short motivation and glossary to make sure all readers are on the same page. The following diff is a suggestion so feel free to edit it as you see fit. I also modified two of the headings to use the word Let me know what you think |
Python notebook containing examples on llvmlite use cases