Add a trusted flag to mCSD administration directories#497
Draft
Dirklectisch wants to merge 6 commits intomainfrom
Draft
Add a trusted flag to mCSD administration directories#497Dirklectisch wants to merge 6 commits intomainfrom
trusted flag to mCSD administration directories#497Dirklectisch wants to merge 6 commits intomainfrom
Conversation
reinkrul
reviewed
Apr 28, 2026
Comment on lines
+14
to
+17
| # admin: | ||
| # example: | ||
| # fhirbaseurl: "https://fhir.example.org/fhir" | ||
| # trusted: true |
Member
There was a problem hiding this comment.
Or we define a directory with key/name root (here example) that is always trusted? Because in the centralized model, there will always be 1 admin directory, and it will always be trusted.
Then we can also remove the decentralized app logic in the future (when we don't need it any more), without changing the configuration structure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a
trustedflag to mCSD administration directories. A trusted directory's contentsare accepted without per-resource validation, intended for directories the
operator controls or otherwise trusts (e.g. the LRZA).
Configured per directory via
mcsd.admin.<name>.trusted: true. Defaults tofalse, soexisting deployments are unaffected.
Behavior
When
trusted: trueon a registered directory:ValidateUpdateshort-circuits after theAllowedResourceTypescheck — per-resourcespoofing checks (URA membership, partOf chain, endpoint reference, etc.) are skipped.
ValidateParentOrganizationsis skipped.remaining consumer in trusted mode).
rather than triggering a full re-fetch.
Explicitly unchanged by
trusted:_sinceandlastUpdateTimesstill applies.discover: truestill discovers and registers leafdirectories. Discovered children are always registered as
trusted: false.isDiscoverableDirectoryfilter (root directories only sync mCSD-directoryEndpointresources) is unchanged.AllowedResourceTypesis still enforced.