Skip to content

[WIP] [engine] update equals & reorder switch case#25

Draft
onheap wants to merge 1 commit intomainfrom
keyao-minor-perf-improvement
Draft

[WIP] [engine] update equals & reorder switch case#25
onheap wants to merge 1 commit intomainfrom
keyao-minor-perf-improvement

Conversation

@onheap
Copy link
Copy Markdown
Owner

@onheap onheap commented Nov 21, 2022

Summary

Test Plan

  • Unit test passed
❯ go test

  • No degradation in performance
❯ go test -bench=BenchmarkEval -run=none -benchtime=3s -benchmem

  • Tested on over a million random expressions
❯ go test -run='TestRandomExpressions'

Reviewers

@onheap

@onheap onheap changed the title [engine] update equals & reorder switch case [WIP] [engine] update equals & reorder switch case Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant