Skip to content

chore: Add missing dependencies to packages#129

Merged
jsteinich merged 1 commit intoopen-constructs:mainfrom
X-Guardian:add-missing-dependencies
Apr 29, 2026
Merged

chore: Add missing dependencies to packages#129
jsteinich merged 1 commit intoopen-constructs:mainfrom
X-Guardian:add-missing-dependencies

Conversation

@X-Guardian
Copy link
Copy Markdown
Contributor

@X-Guardian X-Guardian commented Apr 27, 2026

Description

The migration to using knip for dependency reporting identified several packages that are being used by packages but not listed in the package.json dependencies. The only reason they are working is that they are hoisted to the root of node_modules by Yarn v1.

This PR adds these dependencies are removes them from the relevant ignoreDependencies in knip.jsonc

Package Location
ci-info packages/@cdktn/cli-core/src/lib/error-reporting.ts:13:20
jsii-pacmak/bin/jsii-pacmak packages/@cdktn/provider-generator/lib/get/constructs-maker.ts:24:38
jsii/bin/jsii packages/@cdktn/provider-generator/lib/get/constructs-maker.ts:25:36
@cdktn/provider-schema packages/cdktn-cli/src/bin/cmds/handlers.ts:67:10
@npmcli/ci-detect packages/cdktn-cli/src/bin/cmds/helper/init.ts:41:22
@cdktn/provider-schema packages/cdktn-cli/src/bin/cmds/helper/init.ts:28:10
glob packages/cdktn-cli/src/bin/cmds/helper/var-files.ts:9:23
@babel/parser tools/generate-function-bindings/scripts/generate.ts:11:33
@cdktn/commons tools/generate-function-bindings/scripts/generate.ts:8:10

Checklist

  • I have updated the PR title to match CDKTN's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

@X-Guardian X-Guardian force-pushed the add-missing-dependencies branch from fb215cd to 6b00d9f Compare April 29, 2026 08:17
@X-Guardian X-Guardian marked this pull request as ready for review April 29, 2026 16:37
@X-Guardian X-Guardian requested a review from a team as a code owner April 29, 2026 16:37
@jsteinich jsteinich merged commit 6eaff1e into open-constructs:main Apr 29, 2026
424 checks passed
@X-Guardian X-Guardian deleted the add-missing-dependencies branch May 1, 2026 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants