test: add E2E tests for Tenant CR lifecycle

[somya-bhatnagar]

Summary

Adds E2E test suite for Tenant CR lifecycle validation as part of the test ownership reorganization (RHOAIENG-60709).

Related to https://redhat.atlassian.net/browse/RHOAIENG-59867

Changes

• test/e2e/tests/test_tenant.py - 7 integration tests covering:

  • Tenant singleton existence
  • Ready condition and phase validation
  • Payload processing deployment checks (when Active)
  • Status contract compliance (phase, conditions)
  • Spec well-formedness
  • Kubernetes metav1 condition shape
  • False ownership prevention (MaaS CRs not owned by Tenant)

• test/e2e/README.md - Streamlined documentation focusing on test execution

• test/e2e/scripts/prow_run_smoke_test.sh - Enhanced to include Tenant tests in CI

Test Results

Validated on live OpenShift cluster with operator-based deployment:

• ✅ 5 passing (contract tests, ownership validation, singleton checks)
• ⏭️ 1 skipped (payload-processing not deployed)
• Time: ~5s when Tenant is healthy

Test Ownership Context

This PR is part of Phase 1 (Tenant Tests) of the E2E test ownership reorganization:

• Establishes baseline Tenant CR testing in MaaS CI
• Validates contract between maas-controller and Tenant CR
• Provides foundation for operator CI contract tests (Phase 2)

DSC enable/disable and Tenant deletion lifecycle remain in operator CI scope.

How to Run

cd test/e2e
export DEPLOYMENT_NAMESPACE="opendatahub"  # or wherever Tenant lives
source .venv/bin/activate
pytest tests/test_tenant.py -v

Full smoke test (includes all E2E modules):

./test/e2e/scripts/prow_run_smoke_test.sh

🤖 Generated with Claude Code

[coderabbitai]

Warning

Rate limit exceeded

@somya-bhatnagar has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 58 minutes and 56 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 9a74579d-abd5-4966-bf29-aa5439734c15

📥 Commits

Reviewing files that changed from the base of the PR and between eef74cf and 0e04219.

📒 Files selected for processing (3)

• test/e2e/README.md
• test/e2e/scripts/prow_run_smoke_test.sh
• test/e2e/tests/test_tenant.py

📝 Walkthrough

Walkthrough

The PR updates E2E testing infrastructure by reorganizing the README with structured Quick Start sections, updating the smoke test script to include Tenant and external models test modules in the pytest invocation, and introducing a comprehensive Tenant lifecycle test suite with helpers for cluster interaction via oc, CRUD status validation, readiness polling, and ownership protection checks.

Estimated Code Review Effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Issues

test/e2e/tests/test_tenant.py

1. Insufficient error handling in _oc_json() (Line 27-38): The function catches all exceptions and returns None on failure, masking failures from subprocess calls. Distinguish between JSON parse failures and command execution failures. Log the actual error for debugging.

2. Hardcoded timeout without validation (Line 66-75): _wait_ready_true() uses default timeout of 300 seconds without bounds checking or configurable overrides. Add parameter validation or environment variable support for test duration control.

3. Incomplete ownership validation (Line 142-152): The test_maas_user_crs_not_owned_by_tenant test checks ownerReferences but doesn't validate that ownerReferences are properly set on tenant-managed resources where expected. Test should confirm both negative (CRs not owned) and positive (control resources are owned) scenarios.

4. Missing fixture dependency documentation: The require_tenant_crd fixture (Line 52-64) is not explicitly used in test class definitions, making dependency injection implicit and harder to trace.

test/e2e/scripts/prow_run_smoke_test.sh

5. Assumption of module availability (Line 550-561): The script now imports test_external_models.py and test_tenant.py without verifying these files exist in the test directory or are discoverable. Add an existence check or explicit path validation.

test/e2e/README.md

6. Incomplete environment setup guidance (Line 13-17): The SKIP_DEPLOYMENT=true example lacks documentation of required cluster state (existing tenant CRD, accessible kubeconfig). Add explicit prerequisites for skipped deployment mode.

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'test: add E2E tests for Tenant CR lifecycle' directly and clearly describes the main change: adding end-to-end tests for Tenant Custom Resource lifecycle, which aligns with the primary changeset.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

• Generate code and open pull requests
• Plan features and break down work
• Investigate incidents and troubleshoot customer tickets together
• Automate recurring tasks and respond to alerts with triggers
• Summarize progress and report instantly

Built for teams:

• Shared memory across your entire org—no repeating context
• Per-thread sandboxes to safely plan and execute work
• Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[somya-bhatnagar]

/group-test

[somya-bhatnagar]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[somya-bhatnagar]

/group-test

[somya-bhatnagar]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[somya-bhatnagar]

/group-test

[somya-bhatnagar]

Added a question on github ticket - https://redhat.atlassian.net/browse/RHOAIENG-59867?focusedCommentId=16945433

[rhods-ci-bot]

@somya-bhatnagar: The following test has Succeeded:

OCI Artifact Browser URL

View in Artifact Browser

Inspecting Test Artifacts Manually

To inspect your test artifacts manually, follow these steps:

1. Install ORAS (see the ORAS installation guide).
2. Download artifacts with the following commands:

mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/opendatahub/odh-ci-artifacts:maas-group-test-xdqdp

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: somya-bhatnagar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment