Update sqlx to 0.8.5 #386
Merged
andrewwhitehead merged 1 commit intoApr 23, 2025
Merged
Conversation
pohlm01
added a commit
to openwallet-foundation-labs/tsp
that referenced
this pull request
Apr 22, 2025
Related to openwallet-foundation/askar#383 and openwallet-foundation/askar#386 Signed-off-by: Maximilian Pohl <maximilian@tweedegolf.com>
…anager::begin` function to fix compilation errors Closes #383 Signed-off-by: Maximilian Pohl <maximilian@tweedegolf.com>
Contributor
pohlm01
added a commit
to openwallet-foundation-labs/tsp
that referenced
this pull request
Apr 22, 2025
* Patch `askar` compilation error Related to openwallet-foundation/askar#383 and openwallet-foundation/askar#386 Signed-off-by: Maximilian Pohl <maximilian@tweedegolf.com> * Fix rename problem in doc tests Signed-off-by: Maximilian Pohl <maximilian@tweedegolf.com> --------- Signed-off-by: Maximilian Pohl <maximilian@tweedegolf.com>
andrewwhitehead
approved these changes
Apr 23, 2025
Contributor
andrewwhitehead
left a comment
andrewwhitehead
left a comment
There was a problem hiding this comment.
Looks good, thank you!
|
thanks for this fix, just ran into this. note as well, i believe that the types of sqlx-core are not meant to be used (i.e. not meant to use TransactionManager trait i believe?): see the dev comment in: launchbadge/sqlx#3820 so perhaps the bigger fix is to try move askar away from using these traits directly - not sure what's involved, just a passing comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide additional argument to
Transactionanager::beginfunction to fix compilation errorsCloses #383