Skip to content

[WIP] Support for URL redirects#1082

Draft
veloman-yunkan wants to merge 6 commits into
mainfrom
resolveTargetURL
Draft

[WIP] Support for URL redirects#1082
veloman-yunkan wants to merge 6 commits into
mainfrom
resolveTargetURL

Conversation

@veloman-yunkan
Copy link
Copy Markdown
Collaborator

Related to #1001

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

❌ Patch coverage is 26.66667% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.68%. Comparing base (dde6c50) to head (e9184d0).

Files with missing lines Patch % Lines
src/tools.cpp 26.66% 0 Missing and 22 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1082      +/-   ##
==========================================
- Coverage   55.90%   55.68%   -0.23%     
==========================================
  Files          99       99              
  Lines        5023     5052      +29     
  Branches     2236     2257      +21     
==========================================
+ Hits         2808     2813       +5     
- Misses        733      735       +2     
- Partials     1482     1504      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kelson42
Copy link
Copy Markdown
Contributor

kelson42 commented Apr 29, 2026

AFAIK, this PR is not doing what I requested. If I don't misundestand, this is a problem.

See #1001 (comment)

@veloman-yunkan
Copy link
Copy Markdown
Collaborator Author

@kelson42 My implementation follows the plan proposed in #1001 (comment). The functionality for accessing the new flavour of redirects has to be encapsulated behind an API, and this is what this PR intends to achieve.

@kelson42
Copy link
Copy Markdown
Contributor

kelson42 commented May 4, 2026

The topic has been again discussed live in the last days, and here is the clear requirements my sides:

  • mini-html redirections are a workaround and as such we are no building anything sustainable around them
  • there is in particular no requirement to have a "smart" libzim around mini-html
  • since the very beginning of the libzim, an effort has been made to have the libzim pretty agnostic about the type of data save in it. It is important to not build anything related to mini-html in the libzim (for this reason as well)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants