[WIP] Support for URL redirects#1082
Draft
veloman-yunkan wants to merge 6 commits into
Draft
Conversation
This method is only documented without any implementation being provided.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1082 +/- ##
==========================================
- Coverage 55.90% 55.68% -0.23%
==========================================
Files 99 99
Lines 5023 5052 +29
Branches 2236 2257 +21
==========================================
+ Hits 2808 2813 +5
- Misses 733 735 +2
- Partials 1482 1504 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
AFAIK, this PR is not doing what I requested. If I don't misundestand, this is a problem. See #1001 (comment) |
Collaborator
Author
|
@kelson42 My implementation follows the plan proposed in #1001 (comment). The functionality for accessing the new flavour of redirects has to be encapsulated behind an API, and this is what this PR intends to achieve. |
Contributor
|
The topic has been again discussed live in the last days, and here is the clear requirements my sides:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1001