Make one of the Pex tests more robust.#23283
Merged
benjyw merged 1 commit intopantsbuild:mainfrom Apr 22, 2026
Merged
Conversation
benjyw
added
the
release-notes:not-required
sureshjoshi
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_pex_working_directory[VenvPex]manually deletes the venv dirin the PEX_ROOT, in order to test the situation where pex creation
hits the process cache, while venv seeding misses the pex cache.
However this test was using the real, persistent named_caches dir,
and when pex recreates the venv it also tries to recreate a short
symlink to it, and since we didn't delete the original symlink
(and we can't because we don't know where it is), pex tries
longer and longer prefixes until it gives up. See:
https://github.com/pex-tool/pex/blob/v2.92.3/pex/pex_bootstrapper.py#L553
So if we run the test enough times we eventually hit the "universe is broken"
case in that comment.
The fix is simply to use a tmp_dir as the named_caches dir, like several
other tests in this file. Then pex will only use up two of it 33 possible
increasing prefixes, and we won't hit the apocalypse.